win,build: add Visual Studio 2017 support #11084
Conversation
Add comtypes (http://starship.python.net/crew/theller/comtypes/) Python library to tools. Library provides COM support for Python, which we use to locate Visual Studio 2017 installation path.
Add support for creating VS2017 projects to gyp.
Add support for Visual Studio 2017. Python script is used to query COM server about location of VS installation and installed SDK version. Those are passed to GYP as environment variables.
bzoz
added
build
nodejs-github-bot
added
doc
|
node-gyp PR: nodejs/node-gyp#1101 |
|
@nodejs/build @bnoordhuis |
|
This is pending on the discussion in nodejs/node-gyp#1101 and nodejs/node-gyp#1103 . It would be good to use the same strategy here. |
|
tested and this works as it should, but should we be opting for the C# solution as per nodejs/node-gyp#1130 instead? Much nicer than having to pull in the whole comtypes library if that's all we need. In fact, we could even reach down in to deps/npm/node_modules/node-gyp/lib for that, a little bit gross but zero duplication, we'd just have to fast-track the node-gyp upgrade in our bundled npm ourselves unless npm gets on it early. |
|
@rvagg yes we should use nodejs/node-gyp#1130 method |
|
I'm preparing a PR using that method |
|
P.S. I'm pushing a very light weight VS2017 patch to |
|
PTAL #11852 |
|
probably best close this one out @bzoz |
|
Right. Closing. |
|
The officially supported vswhere tool is now available as part of the install starting today with Visual Studio 15.2 preview 2: https://blogs.msdn.microsoft.com/heaths/2017/04/21/vswhere-is-now-installed-with-visual-studio-2017/. This doesn't fix all the existing installs of VS 2017 but going forward you can now detect the VS install locations and whether C++ tools are available from a scripted environment. I hope this helps your scenario. |
Add support for building node with Visual Studio 2017
With this version VS does not use Windows registry any more, instead it installs a COM server that one can query to obtain list of installed modules and their locations - see this blogpost: https://blogs.msdn.microsoft.com/heaths/2016/09/15/changes-to-visual-studio-15-setup/.
Python does not support communicating with COM servers directly. Chromium project when updating
GNdid not add extra library, instead assuming default installation path with environment variable override (see https://cs.chromium.org/chromium/src/build/vs_toolchain.py?q=vs_toolchain&sq=package:chromium&l=150). I've used the same method to updateGYP- default installation path and default Windows SDK version with override. PR forGYPhas been also opened upstream: https://chromium-review.googlesource.com/#/c/433540/To ease usage for node users, a Python script that can obtain VS installation path and installed SDK version is provided. It depends on
comtypesPython library (https://github.com/enthought/comtypes) which adds support for COM to Python. This script is in turn used byvcbuildto set proper environment variables overrides.For easier review this PR is split into 3 commits:
First commit adds
comtypesPython library totools. It is needed to query VS COM server about installation paths.Second commit adds support for VS2017 to
gyp. Similar to the way it was implemented ingn, it assumes that VS2017 Professional was installed in the default location. User can use two environment variables to overwrite this:VS2017_INSTALLfor installation path andVS2017_SDKfor installed SDK version. This patch was also commited upstream: https://chromium-review.googlesource.com/#/c/433540/Third commit adds support for VS2017 to
vcbuild.bat. We use a Python script that queries VS COM server to determinate installed VS2017 modules and their location.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
win, build, tools
Ref: nodejs/node-gyp#1056
/cc @nodejs/build @nodejs/platform-windows